feat: update with changes from Ulmo by nsprenkle · Pull Request #39 · edx/frontend-app-learning

nsprenkle · 2025-12-23T22:05:20Z

This is a merge of changes from openedx/release/ulmo to what is (in effect) our existing released teak branch (edx/release-teak aliased to edx/release-ulmo).

This should not yet be released, but is a preview of changes for testing purposes.

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

…edx#1700) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

openedx#1736) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…x#1739) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Diana Olarte <diana.olarte@edunext.co>

The commit adds eventlistener which picks up the autoAdvance message and triggers the next sequence. This has the same effect of clicking the next button. Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

…x#1713) * feat: remove waffle flags for managing course outline sidebar * fix: flag and tests * fix: product-tours tests * fix: remove default content for SequenceNavigationSlot and update tests * fix: remove default content for CourseBreadcrumbsSlot * fix: update plugin-slots version and documentation * revert: update plugin-slots version * fix: update tests

…x#1770)

* test: remove snapshots and use rtl tests * test: add expected result on map search

* test: remove snapshots and use rtl tests * test: improve coverage on search results test

…date library version (openedx#1768)

…nedx#1763) * feat: use discount info endpoint for streak discount information * feat: pass course run key to discount code info call * feat: move changes behind a flag * fix: use async IIFE inside useEffect * fix: fix line length * fix: remove default value in dev * fix: improve coverage by adding conditional test based on env value * refactor: move logic inside function * refactor: move functions to utils * fix: ignore merge config

… tab

…kUrlOverrides (openedx#1775)

Bumps [js-toml](https://github.com/sunnyadn/js-toml) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/sunnyadn/js-toml/releases) - [Commits](sunnyadn/js-toml@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: js-toml dependency-version: 1.0.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 5. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

Earlier versions of @openedx/frontend-build used on older version of 'sharp', which caused intermittent installation issues. The version of 'sharp' was updated in @openedx/frontend-build to fix these issues, so the frontend-build version can be updated here, to fix the issues in this project too. See openedx/frontend-build#664 and openedx/frontend-build#665 for more information. The frontend-build dependency was updated by: ``` npm install --package-lock-only @openedx/frontend-build ``` Private-ref: https://tasks.opencraft.com/browse/BB-9953

The previous implementation had a race condition that sometimes prevented XBlocks from being marked as viewed. Users had to scroll or resize the window to trigger visibility tracking instead of having it happen once content loads.

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

Remove @edx/reactifex package from devDependencies as it is no longer needed. Translation extraction functionality has been verified to work correctly without this dependency. Co-Authored-By: Claude <noreply@anthropic.com>

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

…9.2 (openedx#1803) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

….2 (openedx#1804) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: bump frontend-component-header to v6.6.x * chore: bump frontend-component-header to ^8.0.0

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

…enedx#1807) This commit installs version 2.23.1 of @edx/frontend-lib-learning-assistant. This release fixes a bug where the Xpert Learning Assistant was only available to learners in the audit and credit modes. See https://github.com/edx/frontend-lib-learning-assistant/releases/tag/v2.23.1.

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

* feat: add plugin slot for content iframe error component * style: quality * fix: copilot suggestions

…den grades" label in the grade table (openedx#1797) Refactors the grade summary logic to delegate all calculation responsibilities to the backend. Previously, the frontend was performing grade summary computations using data fetched from the API. Now, the API itself provides the fully computed grade summary, simplifying the frontend and ensuring consistent results across clients. Additionally, a "Hidden Grades" label has been added in the grade summary table to clearly indicate sections where grades are not visible to learners. Finally, for visibility settings that depend on the due date, this PR adds a banner on the Progress page indicating that grades are not yet released, along with the relevant due date information.

Copilot

Pull request overview

This PR merges changes from the openedx/release/ulmo branch, bringing multiple feature updates and refactorings to prepare for testing. The changes should not yet be released to production.

Key Changes:

Replaces Chat component with a new LearnerToolsSlot plugin architecture for better extensibility
Implements exam data fetching functionality with comprehensive test coverage
Updates unit title from h3 to h1 for accessibility compliance
Updates certificate image assets and package dependencies

Reviewed changes

Copilot reviewed 30 out of 35 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/plugin-slots/LearnerToolsSlot/*	New plugin slot implementation for learner tools (replaces Chat component)
src/courseware/course/Course.jsx	Replaces Chat with LearnerToolsSlot, adds navigation logic
src/courseware/course/chat/*	Removes old Chat component and tests
src/course-home/progress-tab/*	Adds exam data fetching with hooks and Redux integration
src/plugin-slots/UnitTitleSlot/index.jsx	Changes unit title from h3 to h1 for accessibility
src/index.scss	Adjusts LTI modal height and adds unit-title styling
src/course-home/data/*	Adds exams data API, slice, and thunks
src/generic/assets/*	Updates certificate images from OpenEdX to edX branding
package.json	Updates @edx/frontend-lib-learning-assistant to 2.24.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-23T22:07:57Z

src/courseware/course/sequence/Unit/ContentIFrame.jsx

          && (
          <ModalDialog
-            dialogClassName="modal-lti"
+            className="modal-lti"


The ModalDialog prop has changed from 'dialogClassName' to 'className'. While this appears to be an intentional API update, ensure that this change is compatible with the version of the Modal component being used and that the modal styling is preserved correctly after this change.

Suggested change

className="modal-lti"

className="modal-lti"

dialogClassName="modal-lti"

src/index.scss

Copilot · 2025-12-23T22:07:58Z

src/courseware/course/Course.jsx

-              unitId={unitId}
-            />
-          </>
+        {navigationDisabled || (


The conditional logic here appears inverted. The condition reads "navigationDisabled OR (rest of condition)" but then renders the CourseBreadcrumbsSlot inside. This means the breadcrumbs will render when navigation IS disabled, which seems counterintuitive. The logic should likely be negated to only show breadcrumbs when navigation is NOT disabled.

Copilot · 2025-12-23T22:07:58Z

src/course-home/progress-tab/hooks.jsx

+import { useEffect } from 'react';
+import { useDispatch } from 'react-redux';
+
+import { fetchExamAttemptsData } from '../data/thunks';
+
+export function useGetExamsData(courseId, sequenceIds) {
+  const dispatch = useDispatch();
+
+  useEffect(() => {
+    dispatch(fetchExamAttemptsData(courseId, sequenceIds));
+  }, [dispatch, courseId, sequenceIds]);


The hook dependencies include 'sequenceIds' which is an array. This will cause the effect to re-run on every render even if the array contents are the same, because array identity changes on each render. Consider using a stable reference or memoizing the array more effectively, or use a deep comparison for the dependency.

Suggested change

import { useEffect } from 'react';

import { useDispatch } from 'react-redux';

import { fetchExamAttemptsData } from '../data/thunks';

export function useGetExamsData(courseId, sequenceIds) {

const dispatch = useDispatch();

useEffect(() => {

dispatch(fetchExamAttemptsData(courseId, sequenceIds));

}, [dispatch, courseId, sequenceIds]);

import { useEffect, useMemo } from 'react';

import { useDispatch } from 'react-redux';

import { fetchExamAttemptsData } from '../data/thunks';

export function useGetExamsData(courseId, sequenceIds) {

const dispatch = useDispatch();

const stableSequenceIds = useMemo(

() => sequenceIds,

[JSON.stringify(sequenceIds)],

);

useEffect(() => {

dispatch(fetchExamAttemptsData(courseId, stableSequenceIds));

}, [dispatch, courseId, stableSequenceIds]);

Copilot

Pull request overview

Copilot reviewed 65 out of 75 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

nsprenkle · 2025-12-23T23:23:20Z

I think I got something broken here. Closing for now.

edx-requirements-bot and others added 30 commits June 16, 2025 00:42

chore: update browserslist DB (openedx#1734)

44d952b

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

fix(deps): update dependency @openedx/frontend-build to v14.6.1 (open…

ecd5164

…edx#1700) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency @edx/frontend-component-footer to v14.9.0 (

bc4c8c2

openedx#1736) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency @edx/frontend-platform to v8.4.0 (opened…

462e75f

…x#1739) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

feat!: add design tokens support (openedx#1737)

ddbc212

BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Diana Olarte <diana.olarte@edunext.co>

fix: Fixes the auto_advance feature for video XBlock

b050535

The commit adds eventlistener which picks up the autoAdvance message and triggers the next sequence. This has the same effect of clicking the next button. Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>

chore: update browserslist DB (openedx#1744)

77fcc83

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

chore: update browserslist DB (openedx#1755)

e413464

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

test: deprecate react-test-utils 2/2 (openedx#1751)

a75c89c

test: deprecate react-unit-test-utils 1/2 (openedx#1750)

33d7d66

chore: remove react-unit-test-utils package (openedx#1758)

48270c3

docs: add comprehensive readme documentation for plugin slots (opened…

bf95916

…x#1770)

test: transform snapshot into rtl test 2/2 (openedx#1757)

56a73ee

* test: remove snapshots and use rtl tests * test: add expected result on map search

test: transform snapshot into rtl test 1/2 (openedx#1756)

6892633

* test: remove snapshots and use rtl tests * test: improve coverage on search results test

feat: add FEATURE_ENABLE_CHAT_V2_ENDPOINT to environment files and up…

4c8aa7c

…date library version (openedx#1768)

feat: display the certificate available date if available in progress…

e9121f9

… tab

feat: customize proctoring review requirements link using externalLin…

db29e31

…kUrlOverrides (openedx#1775)

chore: update browserslist DB

2b4a966

feat: updated notification preferences unsubscribe flow (openedx#1778)

579bd03

chore: update browserslist DB (openedx#1783)

f333408

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

chore: update learning assistant plugin 2.23.0 (openedx#1781)

9bf5d01

chore: update browserslist DB (openedx#1784)

d5140a6

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

chore: update browserslist DB (openedx#1788)

c760bc4

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

test: Add Node 24 to CI matrix (openedx#1752)

af50d5a

Agrendalath and others added 14 commits September 18, 2025 16:49

chore: update browserslist DB (openedx#1793)

33f7375

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

build: remove unused @edx/reactifex package

d3188ef

Remove @edx/reactifex package from devDependencies as it is no longer needed. Translation extraction functionality has been verified to work correctly without this dependency. Co-Authored-By: Claude <noreply@anthropic.com>

chore: update browserslist DB (openedx#1795)

a54a1b8

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

build: Upgrade to node 24 and update package-lock.json

e83813d

chore(deps): update dependency @edx/frontend-component-footer to v14.…

694d95a

…9.2 (openedx#1803) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update dependency @edx/frontend-component-header to v6.4…

e556d5b

….2 (openedx#1804) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore: bump frontend-component-header to v8.x.x (openedx#1791)

47b9a43

* chore: bump frontend-component-header to v6.6.x * chore: bump frontend-component-header to ^8.0.0

chore: update browserslist DB (openedx#1799)

d6d229f

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

chore: update browserslist DB (openedx#1808)

7318fb3

Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>

feat: add plugin slot for content iframe error component (openedx#1771)

f91af21

* feat: add plugin slot for content iframe error component * style: quality * fix: copilot suggestions

fix: re-add removed import (openedx#1815)

1d5484f

nsprenkle requested review from Copilot and jristau1984 December 23, 2025 22:05

Copilot started reviewing on behalf of nsprenkle December 23, 2025 22:05 View session

Copilot AI reviewed Dec 23, 2025

View reviewed changes

nsprenkle force-pushed the nsprenkle/teak-to-ulmo-cutover branch from 9697675 to f4fb3b8 Compare December 23, 2025 22:25

nsprenkle changed the base branch from release-ulmo to release-teak December 23, 2025 23:00

nsprenkle force-pushed the nsprenkle/teak-to-ulmo-cutover branch from 097afcf to 444d592 Compare December 23, 2025 23:10

Copilot AI review requested due to automatic review settings December 23, 2025 23:10

Copilot started reviewing on behalf of nsprenkle December 23, 2025 23:10 View session

nsprenkle changed the base branch from release-teak to release-ulmo December 23, 2025 23:11

Copilot AI reviewed Dec 23, 2025

View reviewed changes

chore: merge 'openedx/release/ulmo' into 'edx/release/ulmo'

7989f6d

nsprenkle force-pushed the nsprenkle/teak-to-ulmo-cutover branch from 444d592 to 7989f6d Compare December 23, 2025 23:18

nsprenkle closed this Dec 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update with changes from Ulmo#39

feat: update with changes from Ulmo#39
nsprenkle wants to merge 45 commits intorelease-ulmofrom
nsprenkle/teak-to-ulmo-cutover

nsprenkle commented Dec 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 23, 2025

Uh oh!

Uh oh!

Copilot AI Dec 23, 2025

Uh oh!

Copilot AI Dec 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

nsprenkle commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

	className="modal-lti"
	className="modal-lti"
	dialogClassName="modal-lti"

Conversation

nsprenkle commented Dec 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

nsprenkle commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants